Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #370: standardize rsiviz port configuration and enable devbox for rsiviz #371

Merged
merged 7 commits into from
Aug 25, 2023
Merged

Fix #370: standardize rsiviz port configuration and enable devbox for rsiviz #371

merged 7 commits into from
Aug 25, 2023

Conversation

e-carlin
Copy link
Member

No description provided.

robnagler
robnagler requested changes Aug 24, 2023
View reviewed changes
rsconf/component/rsiviz.py Show resolved Hide resolved
rsconf/component/rsiviz.py Outdated Show resolved Hide resolved
tests/pkcli/build_data/1.in/db/000.yml Outdated Show resolved Hide resolved
rsconf/component/devbox.py Outdated Show resolved Hide resolved
rsconf/component/devbox.py Show resolved Hide resolved
robnagler
robnagler requested changes Aug 24, 2023
View reviewed changes
Copy link
Member

@robnagler robnagler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pksetdefault needs to be changed.

@e-carlin e-carlin merged commit 1a14565 into master Aug 25, 2023
2 checks passed
@e-carlin e-carlin deleted the 370-rsiviz-networking branch August 25, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robnagler robnagler robnagler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@e-carlin @robnagler