Draft point cloud STAC extension #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cholmes
approved these changes
Dec 31, 2018
Closed
m-mohr
requested changes
Jan 2, 2019
m-mohr
requested changes
Jan 2, 2019
m-mohr
reviewed
Jan 2, 2019
m-mohr
reviewed
Jan 3, 2019
m-mohr
approved these changes
Jan 3, 2019
There was a problem hiding this comment.
Thanks for the changes. Looks fine, up-to-date and consistent now. Can't comment very much on the actual content as I am not very much into Point Clouds though, so another review would be great, I think.
By the way, should any of the fields be required or are these all optional (which they are currently)?
|
Some of them should be required. I'll go through and denote. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A draft point cloud STAC extension based on PDAL info output for geospatial point clouds.