Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow two spatial bounding boxes in Collections #1260

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Disallow two spatial bounding boxes in Collections #1260

merged 1 commit into from
Nov 7, 2023

Conversation

m-mohr
Copy link
Collaborator

@m-mohr m-mohr commented Oct 5, 2023

Related Issue(s): #1243

Proposed Changes:

Two spatial bounding boxes in a Collection don't make sense and will be reported as invalid by the schema. ([#1243]

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
  • This PR has no breaking changes.
  • I have added my changes to the CHANGELOG
    or a CHANGELOG entry is not required.
  • This PR affects the STAC API spec,
    and I have opened issue/PR #XXX to track the change.

@m-mohr m-mohr changed the base branch from master to dev October 5, 2023 15:32
@m-mohr m-mohr added this to the 1.1 milestone Oct 5, 2023
@m-mohr m-mohr linked an issue Oct 5, 2023 that may be closed by this pull request
Collection bbox schema #1243
Closed
@m-mohr m-mohr mentioned this pull request Oct 5, 2023
Closed
emmanuelmathot
emmanuelmathot approved these changes Nov 6, 2023
View reviewed changes
Copy link
Collaborator

@emmanuelmathot emmanuelmathot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

@emmanuelmathot emmanuelmathot merged commit 79fe39a into dev Nov 7, 2023
@m-mohr m-mohr deleted the spatial-extent branch November 7, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmanuelmathot emmanuelmathot emmanuelmathot approved these changes

@philvarner philvarner philvarner approved these changes

@cholmes cholmes Awaiting requested review from cholmes

@matthewhanson matthewhanson Awaiting requested review from matthewhanson

@jbants jbants Awaiting requested review from jbants

Assignees
No one assigned
Labels
json schema stac-collection
Projects
None yet
Milestone
1.1.0-beta.1
Development

Successfully merging this pull request may close these issues.

Collection bbox schema
3 participants
@m-mohr @philvarner @emmanuelmathot