Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename 'scientific extension' to 'citation extension' #990

Closed
tedhabermann opened this issue Feb 15, 2021 · 6 comments · Fixed by #1003
Closed

Rename 'scientific extension' to 'citation extension' #990

tedhabermann opened this issue Feb 15, 2021 · 6 comments · Fixed by #1003
Assignees
Milestone

Comments

@tedhabermann
Copy link

A name that reflects what is in this extension would be more appropriate. Maybe Citation extension.

@schwehr
Copy link
Contributor

schwehr commented Feb 17, 2021

@tedhabermann, I don't know how this changes your thinking, but (Link Object)[https://github.com/radiantearth/stac-spec/blob/master/catalog-spec/catalog-spec.md#link-object) and (Provider Object)[https://github.com/radiantearth/stac-spec/blob/master/collection-spec/collection-spec.md#provider-object] are directly about connections.

For Earth Engine, there are source and cite-as in the links:

  "links": [
    {
      "rel": "self",
      "href": "https://earthengine-stac.storage.googleapis.com/catalog/NOAA_GOES_16_FDCC.json"
    },
    {
      "rel": "parent",
      "href": "https://earthengine-stac.storage.googleapis.com/catalog/catalog.json"
    },
    {
      "rel": "root",
      "href": "https://earthengine-stac.storage.googleapis.com/catalog/catalog.json"
    },
    {
      "rel": "preview",
      "href": "https://mw1.google.com/ges/dd/images/NOAA_GOES_16_FDCC_sample.png"
    },
    {
      "rel": "license",
      "href": "https://developers.google.com/earth-engine/datasets/catalog/NOAA_GOES_16_FDCC#terms-of-use"
    },
    {
      "rel": "source",
      "href": "https://console.cloud.google.com/storage/browser/gcp-public-data-goes-16/ABI-L2-FDCC/"
    },
    {
      "rel": "cite-as",
      "href": "https://doi.org/10.1175/BAMS"
    }
  ],

And providers:

  "providers": [
    {
      "name": "NOAA",
      "roles": [
        "producer",
        "licensor"
      ],
      "url": "https://data.noaa.gov/dataset/dataset/noaa-goes-r-series-advanced-baseline-imager-abi-level-2-fire-hot-spot-characterization-fdc"
    },
    {
      "name": "Google Earth Engine",
      "roles": ["host"],
      "url": "https://developers.google.com/earth-engine/datasets/catalog/NOAA_GOES_16_FDCC"
    }
  ],

@matthewhanson
Copy link
Collaborator

I agree, scientific is a poor name. I can think of several other things a scientific extension might deal with but I'd be wrong.

citation is more descriptive, I would support a change here.

@cholmes cholmes added this to the 1.0.0-RC.1 milestone Feb 18, 2021
@cholmes cholmes changed the title The scientific extension is really about connections Rename 'scientific extension' to 'citation extension' Feb 22, 2021
@cholmes
Copy link
Contributor

cholmes commented Feb 22, 2021

I agree that citation is a bit more descriptive as to what this is. Changed the issue title to reflect it.

Do we think the prefix needs to change? Or do we keep sci:?

My only hesitation is that in #946 we agreed to make scientific to be a 'core' extension. I don't think we should change the prefix right before deeming it stable. But if we just want to change the name of the extension I think that's ok.

@m-mohr - any thought on this issue? As you're the owner of this extension.

@m-mohr
Copy link
Collaborator

m-mohr commented Feb 22, 2021

The scientific extension was meant to evolve a bit over time so that other fields would be added. It never took place so now it is indeed not the best name.

I'd be fine with renaming it to a different name, but I guess changing the prefix is not ideal indeed.

What about simply renaming it to "Scientific Citation Extension" and leave everything else as it is?

@m-mohr
Copy link
Collaborator

m-mohr commented Feb 22, 2021

I've created PR #1003 as a potential solution, let's discuss there.

@m-mohr m-mohr self-assigned this Feb 22, 2021
@cholmes
Copy link
Contributor

cholmes commented Feb 22, 2021

+1 to renaming as scientific citation extension.

cholmes added a commit that referenced this issue Feb 23, 2021
Renamed "Scientific Extension" to "Scientific Citation Extension" #990
@cholmes cholmes closed this as completed Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants