Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #54 #69

Merged
merged 1 commit into from
Dec 1, 2020
Merged

Fix #54 #69

merged 1 commit into from
Dec 1, 2020

Conversation

m-mohr
Copy link
Collaborator

@m-mohr m-mohr commented Dec 1, 2020

Related Issue(s): #54

Proposed Changes:

  1. Fix mismatch in item property.datetime definition in spec and openapi

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
  • This PR has no breaking changes.
  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.
  • OpenAPI files only: I have run npm run generate-all to update the generated OpenAPI files.

@m-mohr m-mohr added this to the 1.0.0-beta.1 milestone Dec 1, 2020
@m-mohr m-mohr linked an issue Dec 1, 2020 that may be closed by this pull request
Missmatch in item property.datetime definition in spec and openapi.yaml #54
Closed
cholmes
cholmes approved these changes Dec 1, 2020
View reviewed changes
Copy link
Collaborator

@cholmes cholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for grabbing this, it'd slipped my mind to do, and would have taken me much longer than you.

@cholmes cholmes merged commit 6af6ec0 into master Dec 1, 2020
@m-mohr m-mohr deleted the fix-54 branch December 1, 2020 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cholmes cholmes cholmes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

Missmatch in item property.datetime definition in spec and openapi.yaml
2 participants
@m-mohr @cholmes