Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter Extension - add Accent and Case-insensitive Comparison conform… #235

Merged

Conversation

philvarner
Copy link
Collaborator

@philvarner philvarner commented Dec 6, 2021

Related Issue(s): #233

Proposed Changes:

  1. Add mention of Accent and Case-insensitive Comparison conformance class to Filter Extension
  2. add ACCENTI and CASEI examples

CQL2 spec merge is here: https://github.com/opengeospatial/ogcapi-features/pull/641/files

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
  • This PR has no breaking changes.
  • This PR does not make any changes to the core spec in the stac-spec directory (these are included as a subtree and should be updated directly in radiantearth/stac-spec)
  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.

Copy link
Collaborator

@m-mohr m-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but maybe don't highlight/show ACCENTI in STAC API yet until it has been decided on?

@philvarner
Copy link
Collaborator Author

Looks good, but maybe don't highlight/show ACCENTI in STAC API yet until it has been decided on?

Yeah, I think I'm going to put this PR in draft and wait until this gets nailed down a bit more.

@philvarner philvarner marked this pull request as draft December 7, 2021 15:51
@philvarner
Copy link
Collaborator Author

Accent and Case insensitive comparison class code was merged to the CQL2 spec this morning, so this pr is ready.

@philvarner philvarner marked this pull request as ready for review January 31, 2022 14:13
@philvarner philvarner merged commit 32c3d83 into radiantearth:dev Feb 10, 2022
@philvarner philvarner deleted the Accent-and-Case-insensitive-Comparison branch February 10, 2022 15:59
@philvarner philvarner added this to the 1.0.0-rc.1 milestone Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants