Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup Context Extension text #21

Merged
merged 2 commits into from
May 20, 2020

Conversation

philvarner
Copy link
Collaborator

Related Issue(s): n/a

Proposed Changes:

  1. Remove the non-existent "next" parameter as required in the yaml spec
  2. Reorder properties so they're always in order "returned, limit, matched"

PR Checklist:

  • This PR has no breaking changes.
  • CHANGELOG entry is not required.
  • API only: I have run npm run generate-all to update the generated OpenAPI files.

"matched": 1092873,
"returned": 9
}
"returned": 1,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this example is not correct, since the "returned" value matches the number of features.

@@ -1644,9 +1644,12 @@ components:
context:
type: object
required:
- next
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed, as it is no longer a field at all

Copy link
Collaborator

@m-mohr m-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be mostly fixes, but maybe still add a CHANGELOG entry?

@philvarner
Copy link
Collaborator Author

Seems to be mostly fixes, but maybe still add a CHANGELOG entry?
@m-mohr added

@philvarner philvarner merged commit aed97ce into radiantearth:dev May 20, 2020
@philvarner philvarner deleted the context-yaml-fixes branch May 20, 2020 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants