-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relative -> absolute links for stac-spec references #115
Conversation
Pins these links to v1.0.0-rc.1 of the core spec
@duckontheweb we've been linking to the master branch of the stac-spec from the extensions, rather than to the v1.0.0-rc.1 tag. It saves us from having to update the links (which once we get to 1.0.0 should be an uncommon occurrence), but there's also a risk that links could become broken. For now, I think linking to master branch is probably best. thoughts @cholmes ? |
I'm definitely of two minds on this. I do think the rc.1 link is less good, because it's going to be rc.2 soon and then 1.0.0. But I don't love going straight to master, since if stac spec were to go to 2.0 and then someone was looking at STAC API release 1.0.0 they'd follow a link there, which isn't really what STAC API is based on. I think best may be to do 'master' for right now, but once STAC 1.0.0 is at then we could change it to link there... |
Yeah, I'm a little back-and-forth on this, too. It's not hard to update the |
@matthewhanson @cholmes I updated the links to point to |
Why not just update the submodule? |
@duckontheweb - are you able to update this PR so it uses a sub-tree? Or would that need to be a new PR? Or some other way to get that working? |
I opened #119 and marked it as WIP until we confirmed that's the way we wanted to go. |
Closed via #119 |
Related Issue(s): #
#114
Proposed Changes:
radiantearth/stac-spec
repo.All URLs are pinned to
v1.0.0-rc.1
.PR Checklist:
I have added my changes to the CHANGELOG ora CHANGELOG entry is not required.