Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hoot streaming reader #2

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

maxgrossman
Copy link

Providing hootenanny with [out:json] in an overpass query leads it to use a non-streamable json reader. As a result, the convert command ends up trying to buffer all the data it gets from the overpass query into memory before writing it out to a file. The xml reader can be "stream" the incoming data from overpass, so we want to use it.

This change allows the overpass output type to be chosen when the Hootenanny class is initialized. If no choice, parameter, is provided we default to xml.

@maxgrossman maxgrossman requested a review from jbronn January 11, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant