GitHub actions #155
Merged
GitHub actions #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the error ``` OSC error A 8: nodename nor servname provided, or not known ``` from the `test_server_thread` test.
One of those fixes is to make the CI build static on Windows. If you do not do this, you will get strange errors like ``` nonblocking_server_example.obj : error LNK2019: unresolved external symbol lo_server_new referenced in function main [D:\a\liblo\liblo\bld\nonblocking_server_example.vcxproj] nonblocking_server_example.obj : error LNK2019: unresolved external symbol lo_server_recv_noblock referenced in function main [D:\a\liblo\liblo\bld\nonblocking_server_example.vcxproj] nonblocking_server_example.obj : error LNK2019: unresolved external symbol lo_server_add_method referenced in function main [D:\a\liblo\liblo\bld\nonblocking_server_example.vcxproj] ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes CI run - mostly.
There are still sporadic MacOS issues - likely due to an issue in
lo_server_recvreturning occasionally another number than expected, which looks like it was not blocking on MacOS. Anyways, this remains hard to debug, and repeating the runs always succeed.