Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #14296 - Segfault in ragg2 #14308

Merged
merged 1 commit into from
Jun 15, 2019
Merged

Fix #14296 - Segfault in ragg2 #14308

merged 1 commit into from
Jun 15, 2019

Conversation

radare
Copy link
Collaborator

@radare radare commented Jun 15, 2019

This fix is probably not good, but we should add a test for it, and at some point rework on the ragg2 api cleanup with some refactorings

@radare radare added this to the 3.6.0 milestone Jun 15, 2019
@codecov-io
Copy link

Codecov Report

Merging #14308 into master will decrease coverage by <.01%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14308      +/-   ##
==========================================
- Coverage   37.85%   37.85%   -0.01%     
==========================================
  Files         950      950              
  Lines      305735   305739       +4     
==========================================
- Hits       115732   115731       -1     
- Misses     190003   190008       +5
Impacted Files Coverage Δ
libr/egg/egg_lang.c 37.08% <25%> (-0.06%) ⬇️
libr/core/project.c 57.47% <0%> (-0.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b282620...69019a0. Read the comment docs.

@radare radare merged commit 93af319 into master Jun 15, 2019
@Maijin Maijin deleted the fix-ragg2-crash branch July 1, 2019 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants