Do not close IO when RBuffer is freed

[ret2libc]

Fixes #14115

[thestr4ng3r]

❤

[radare]

why freeing a buffer asasociated with an fd should close the fd? imho rbuf should not handle that.

…

On 21 May 2019, at 10:40, Riccardo Schirone ***@***.***> wrote: Fixes #14115 <#14115> You can view, comment on, or merge this pull request online at: #14123 <#14123> Commit Summary Add paramater to let user choose if RBuffer needs to close IO File Changes M libr/bin/p/bin_dyldcache.c <https://github.com/radare/radare2/pull/14123/files#diff-0> (2) M libr/core/cbin.c <https://github.com/radare/radare2/pull/14123/files#diff-1> (2) M libr/include/r_util/r_buf.h <https://github.com/radare/radare2/pull/14123/files#diff-2> (4) M libr/util/buf.c <https://github.com/radare/radare2/pull/14123/files#diff-3> (3) M libr/util/buf_io.c <https://github.com/radare/radare2/pull/14123/files#diff-4> (7) Patch Links: https://github.com/radare/radare2/pull/14123.patch <https://github.com/radare/radare2/pull/14123.patch> https://github.com/radare/radare2/pull/14123.diff <https://github.com/radare/radare2/pull/14123.diff> — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#14123>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAG75FRTBINJDVGTGEGVLXLPWOYOXANCNFSM4HOIVKNA>.

[ret2libc]

Ok it seems a good point @radare ! Maybe it's better to just avoid the free at all, given it is not the buffer that creates the file it shouldn't be the buffer to close/free it. Nice catch, I will update the PR soon.

[radare]

+1

…

On 21 May 2019, at 12:16, Riccardo Schirone ***@***.***> wrote: Ok it seems a good point @radare <https://github.com/radare> ! Maybe it's better to just avoid the free at all, given it is not the buffer that creates the file it shouldn't be the buffer to close/free it. Nice catch, I will update the PR soon. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#14123>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAG75FSVLHEZX6N2MSQKG2LPWPDXPANCNFSM4HOIVKNA>.