rasm2 fix for -D #11
Merged
rasm2 fix for -D #11
+3
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix in commit d843506 was checking for ret < 0, but as ret is initialized with 0 rasm -D would always finish after a single instruction. This commit reverts to the previous commit and adds a check to see if the end of the buffer was reached.
ghost
mentioned this pull request
This was referenced Nov 10, 2013
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Apr 27, 2015
This was referenced Aug 17, 2018
Closed
ghost
mentioned this pull request
yossizap
pushed a commit
to yossizap/radare2
that referenced
this pull request
Dec 30, 2019
Prio select style > hover style
This was referenced Mar 21, 2020
Closed
4 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix in commit d843506 was checking for ret < 0, but as ret is initialized with 0 rasm -D would always finish after a single instruction.
This commit reverts to the previous commit and adds a check to see if the end of the buffer was reached.