Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flags command - add comments support [feature request] #20

Closed
XVilka opened this issue Oct 25, 2012 · 2 comments
Closed

flags command - add comments support [feature request] #20

XVilka opened this issue Oct 25, 2012 · 2 comments

Comments

@XVilka
Copy link
Contributor

XVilka commented Oct 25, 2012

Idea is to use such syntax:

f name 12 @ 33 "comment" ; set flag 'name' with length 12 at offset 13 and 'comment'
f name 12 33 "comment" ; same as above
f+name 12 33 "comment" ; like above but creates new one if doesnt exist

And show these comments in analysis output then.

And change for bindings api too, to support comments.

@radare
Copy link
Collaborator

radare commented Oct 26, 2012

90% implemented in local, expect commit soon

On Oct 26, 2012, at 0:33, Anton Kochkov [email protected] wrote:

Idea is to use such syntax:

f name 12 @ 33 "comment" ; set flag 'name' with length 12 at offset 13 and 'comment'
f name 12 33 "comment" ; same as above
f+name 12 33 "comment" ; like above but creates new one if doesnt exist

And show these comments in analysis output then.

And change for bindings api too, to support comments.


Reply to this email directly or view it on GitHub.

@radare
Copy link
Collaborator

radare commented Oct 26, 2012

done and pushed :)

Syntax is:

f name 12 33 comment # spaces accepted, no need for quotes

you can also get/set the comment of a flag like this:

fC name # get comment for flag 'name'
fC name comment # set comment for flag 'name'

flag comments are displayed on the top line of the label in the disassembly

if more than one flag is in the same offset that comment may be hidden

@radare radare closed this as completed Oct 26, 2012
@radare radare mentioned this issue Oct 25, 2015
17 tasks
@radare radare mentioned this issue Nov 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants