Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update foodie gem and guide, removed aruba step extensions #38

Merged
merged 2 commits into from
Nov 4, 2013

Conversation

charlespeach
Copy link
Contributor

Hi @radar,

Ive updated the foodie gem example to include the latest versions of most dependant gems, the most important update being aruba. The guide has been updated to reflect the change in the example gem code.

Aruba now includes step definitions for checking multi-line contents of a file, making the aruba step definition extensions obsolete (any one new to the guide would get a Cucumber::Ambiguous match error, like this guy: http://stackoverflow.com/questions/17767030/how-to-resolve-a-cucumberambiguous-match-error-while-testing-a-cli-in-aruba).

I also updated a few paths/to/file_names.ext to use the inline code syntax ("`") instead of underscores, as it was making them render incorrectly. Rubygems source was also updated to source 'https://rubygems.org' (fixed deprecation warning).

Also removed the aruba step difinition extentions, as that step is
now included within aruba!
* Aruba now contains step definitions for reading the text file

Other changes:
* Because my editor removes whitespace, there is a few cleanup changes
* Changed the markdown syntax on some /path/to/text_file.txt, as some
  were breaking because of the inclusion of an underscore
@charlespeach
Copy link
Contributor Author

@radar Also sorry there is a few whitespace changes, as my editor automatically strips trailing whitespace (keeping inline with community standards) etc

@charlespeach
Copy link
Contributor Author

@radar Also just noticed this is a duplicate of PR from @jarsbe (#37). However this PR actually updates the Gemfile.lock, bringing in the latest changes from aruba.

@radar
Copy link
Owner

radar commented Nov 4, 2013

Looks fine to me. Thanks @charlespeach!

@radar radar closed this Nov 4, 2013
@radar radar reopened this Nov 4, 2013
radar added a commit that referenced this pull request Nov 4, 2013
Update foodie gem and guide, removed aruba step extensions
@radar radar merged commit 69335f6 into radar:master Nov 4, 2013
@charlespeach charlespeach deleted the feature/update-gem-development branch November 4, 2013 03:01
radar pushed a commit that referenced this pull request Jun 30, 2017
Small update for patterns.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants