Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Add Dzongkha #134

Merged
merged 7 commits into from
Sep 27, 2024
Merged

[FEATURE] Add Dzongkha #134

merged 7 commits into from
Sep 27, 2024

Conversation

KinWang-2013
Copy link
Contributor

This PR adds support for Dzongkha which is the national language of Bhutan 🇧🇹

@KinWang-2013
Copy link
Contributor Author

@radar please check this

dblock
dblock requested changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@dblock dblock left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can we add some more tests than just for 1 second, please?

I know it's unrelated, but we do need to fix CI. If you could please help out do the upgrades, we can probably drop 2.4 and add 3.2 and 3.1 (separate PR would be great).

@KinWang-2013
Copy link
Contributor Author

Looks good! Can we add some more tests than just for 1 second, please?

I know it's unrelated, but we do need to fix CI. If you could please help out do the upgrades, we can probably drop 2.4 and add 3.2 and 3.1 (separate PR would be great).

sure, I will

@KinWang-2013
Copy link
Contributor Author

@dblock added some more tests, I will try doing upgrades in another PR

@KinWang-2013
Copy link
Contributor Author

@dblock added some more tests, I will try doing upgrades in another PR

@dblock please check, the other PR is #135

@dblock
Copy link
Collaborator

dblock commented Sep 27, 2024

CI should pass now after #135, rebase?

@KinWang-2013
Copy link
Contributor Author

CI should pass now after #135, rebase?

done

dblock
dblock requested changes Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, missing a period in CHANGELOG, sorry!

CHANGELOG.md Outdated Show resolved Hide resolved
@KinWang-2013 @dblock
Update CHANGELOG.md
6d366a2 
Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]>
@KinWang-2013
Copy link
Contributor Author

Nit, missing a period in CHANGELOG, sorry!

updated, thanks

@dblock dblock merged commit 650fadb into radar:master Sep 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KinWang-2013 @dblock