Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After upgrade from 4.0.1 to 5.3.1 option[:vague] raises error #126

Merged
merged 11 commits into from
Aug 18, 2021
Merged

After upgrade from 4.0.1 to 5.3.1 option[:vague] raises error #126

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5e16b7f
add spec for excluding 3rd argument 'include secs'
mozcomp Jun 18, 2021
52bfae5
pass options to 4th argument unless 3rd supplied
mozcomp Jun 18, 2021
e19819f
additional test to guard against options already provided
mozcomp Jun 18, 2021
27a5ee4
re-instate argument handling from DOTIW method
mozcomp Jun 21, 2021
13e3c67
Clarification in readme,
mozcomp Jul 1, 2021
2b99fff
ensure incoming hash remains unmodified
mozcomp Jul 10, 2021
4d41a21
update changelog
mozcomp Jul 10, 2021
959f834
UPD: option setting - less work per recomender
mozcomp Aug 16, 2021
9b3fae0
Backtrack change to changelog
mozcomp Aug 16, 2021
5b9ebef
Backtrack previous change add quotes
mozcomp Aug 16, 2021
30dbfc2
Fix: complaining bots ..
mozcomp Aug 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
## 5.3.2 (Next)

- * Your contribution here.
* Your contribution here.
* [#126](https://github.com/radar/distance_of_time_in_words/pull/126): Fixes `#distance_of_time_in_words_to_now` with `vague: true` when supplied without `include_seconds` argument - [@mozcomp](https://github.com/mozcomp)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're missing a period at the end. A bot will complain.


## 5.3.1 (2021/03/26)

Expand Down