Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VPC Flowlog IAM policy to prevent recreation of CW Log Group after deletion #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johnctitus
Copy link
Contributor

Corresponding Issue(s):
Summary of change(s):
  • Updates IAM policies to use jsonencode method instead of multiline strings.
  • Updates VPC FlowLogs IAM Policy to remove ability to create log groups.
    • This permission was allowing the Log Group to be recreated after its destruction when in flight FlowLog messages were processed.
Reason for Change(s):
  • Undesired behavior of Log Group being recreated after destruction.
Will the change trigger resource destruction or replacement? If yes, please provide justification:

No

Does this update/change involve issues with other external modules? If so, please describe the scenario.

No

If input variables or output variables have changed or has been added, have you updated the README?

N/A

Do examples need to be updated based on changes?

N/A

Note to the PR requester about Closing PR's

Please message the person that opened the issue when auto closing it on slack, as well as any other stake holders of deep interest. Only close the issue if you believe that the issue is fully resolved with this PR.

This PR may auto close the issue associated with it. If you feel the issue is not resolved please reopen the issue.

@johnctitus johnctitus added the WIP label Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant