HCL2\Terraform v0.12 conversion #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnctitus
force-pushed
the
MPCSUPENG-855
branch
from
59309ce to
b39d125
Compare
johnctitus
force-pushed
the
MPCSUPENG-855
branch
from
b39d125 to
eabac77
Compare
johnctitus
force-pushed
the
MPCSUPENG-855
branch
5 times, most recently
from
7ef8f04 to
e250096
Compare
johnctitus
force-pushed
the
MPCSUPENG-855
branch
from
e250096 to
a403880
Compare
|
LGTM. DO EEEET |
twistedgrim
approved these changes
Jan 23, 2020
cwgem
approved these changes
Jan 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding Issue(s):
MPCSUPENG-855
Summary of change(s):
Reason for Change(s):
Terraform 0.12 support
Will the change trigger resource destruction or replacement? If yes, please provide justification:
No, none of the changes should result in the replacement of resources.
Does this update/change involve issues with other external modules? If so, please describe the scenario.
If input variables or output variables have changed or has been added, have you updated the README?
Readme should be up to date.
Do examples need to be updated based on changes?
Examples were converted during the process and updated to the expected release number.
Note to the PR requester about Closing PR's
Please message the person that opened the issue when auto closing it on slack, as well as any other stake holders of deep interest. Only close the issue if you believe that the issue is fully resolved with this PR.
This PR may auto close the issue associated with it. If you feel the issue is not resolved please reopen the issue.