-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attach Bucket Policy as part of module #26
Open
gdelvalle
wants to merge
5
commits into
master
Choose a base branch
from
bucketpolicy
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdelvalle
force-pushed
the
bucketpolicy
branch
from
August 10, 2021 17:07
96efb60
to
102978d
Compare
twistedgrim
previously approved these changes
Aug 10, 2021
mdfilio
reviewed
Aug 10, 2021
stevengorrell
previously approved these changes
Aug 10, 2021
@martijnvdgrift , I was still getting |
gdelvalle
dismissed stale reviews from stevengorrell and twistedgrim
via
August 10, 2021 19:46
0bfdd53
gdelvalle
force-pushed
the
bucketpolicy
branch
from
August 10, 2021 19:46
415b733
to
0bfdd53
Compare
mdfilio
approved these changes
Aug 10, 2021
twistedgrim
approved these changes
Aug 10, 2021
gdelvalle
changed the title
Attach Bucketpolicy as part of module
Attach Bucket Policy as part of module
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change(s):
Supercedes #25
Reason for Change(s):
If a bug, describe error scenario, including expected behavior and actual behavior.
If an enhancement, describe the use case and the perceived benefit(s).
Easier way to add Bucket policies and Ownership controls. An additional benefit is that with everything in this module, you can set explicit DependsOns. Without this you get:
A conflicting conditional operation is currently in progress against this resource.
errors when performing operations onaws_s3_bucket_public_access_block
andaws_s3_bucket_ownership_controls
Will the change trigger resource destruction or replacement? If yes, please provide justification:
No
Does this update/change involve issues with other external modules? If so, please describe the scenario.
No
If input variables or output variables have changed or has been added, have you updated the README?
yes
Do examples need to be updated based on changes?
New example is added.
Note to the PR requester about Closing PR's
Please message the person that opened the issue when auto closing it on slack, as well as any other stake holders of deep interest. Only close the issue if you believe that the issue is fully resolved with this PR.
This PR may auto close the issue associated with it. If you feel the issue is not resolved please reopen the issue.