Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach Bucket Policy as part of module #26

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

gdelvalle
Copy link
Contributor

Summary of change(s):

Supercedes #25

Reason for Change(s):
  • If a bug, describe error scenario, including expected behavior and actual behavior.

  • If an enhancement, describe the use case and the perceived benefit(s).
    Easier way to add Bucket policies and Ownership controls. An additional benefit is that with everything in this module, you can set explicit DependsOns. Without this you get: A conflicting conditional operation is currently in progress against this resource. errors when performing operations on aws_s3_bucket_public_access_block and aws_s3_bucket_ownership_controls

Will the change trigger resource destruction or replacement? If yes, please provide justification:

No

Does this update/change involve issues with other external modules? If so, please describe the scenario.

No

If input variables or output variables have changed or has been added, have you updated the README?

yes

Do examples need to be updated based on changes?

New example is added.

Note to the PR requester about Closing PR's

Please message the person that opened the issue when auto closing it on slack, as well as any other stake holders of deep interest. Only close the issue if you believe that the issue is fully resolved with this PR.

This PR may auto close the issue associated with it. If you feel the issue is not resolved please reopen the issue.

twistedgrim
twistedgrim previously approved these changes Aug 10, 2021
variables.tf Outdated Show resolved Hide resolved
stevengorrell
stevengorrell previously approved these changes Aug 10, 2021
@gdelvalle
Copy link
Contributor Author

@martijnvdgrift , I was still getting OperationAborted: A conflicting conditional operation is currently in progress against this resource.. From the run log it suggested the policy and the ownership change were conflicting. I updated the depends clause so that the policy and bucket ownership were serialized similar to what you had done prior.

@gdelvalle gdelvalle added the WIP label Aug 10, 2021
@gdelvalle gdelvalle changed the title Attach Bucketpolicy as part of module Attach Bucket Policy as part of module Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

5 participants