Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong background color for recycling symbol. #644

Closed
soegaard opened this issue Sep 24, 2023 · 5 comments · Fixed by racket/gui#309
Closed

Wrong background color for recycling symbol. #644

soegaard opened this issue Sep 24, 2023 · 5 comments · Fixed by racket/gui#309

Comments

@soegaard
Copy link
Member

This screenshot is from DrRacket 8.10 [cs] on macOS using the "Tol's White on Black" theme.

image

It shows tha the background color of the recycling symbol doesn't match the panel color.

@rfindler
Copy link
Member

It's also true in black-on-white mode:

Screenshot 2023-09-24 at 8 15 51 PM

It is somewhat intentional, as this place also responds to clicks (triggering a GC).

@soegaard
Copy link
Member Author

Ah! It's the black outline that makes it look good in light mode.
Maybe add a white outline in dark mode?

@rfindler
Copy link
Member

Ah, that change isn't the whole story, I guess: the gc icon doesn't react to the change to dark mode until you create a new frame. But does it look okay? Or should it be a bit less bright, perhaps?

@sorawee
Copy link
Contributor

sorawee commented Oct 7, 2023

This is what it looks like now:
Screenshot 2023-10-07 at 10 03 53 AM

The switch from white to black or black to white still doesn't happen immediately -- it only switches when a new window is created. But I think that's a separate issue.

@rfindler
Copy link
Member

rfindler commented Oct 7, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants