Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: PUC-598: create or set baremetal flavor #454

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

haseebsyed12
Copy link
Contributor

@haseebsyed12 haseebsyed12 commented Nov 8, 2024

argo template create baremetal-flavor.yaml
argo submit -n argo-events --from workflowtemplate/baremetal-flavor -p flavor_name="gp4.small" -p flavor_properties="--property resources:CUSTOM_BAREMETAL_GP4SMALL=1 --property resources:VCPU=2 --property resources:MEMORY_MB=4096 --property resources:DISK_GB=20"

workflows-executed

@haseebsyed12 haseebsyed12 changed the title PUC-598: create or set baremetal flavour feat: PUC-598: create or set baremetal flavour Nov 8, 2024
@haseebsyed12 haseebsyed12 force-pushed the puc-598-create-flavors branch 3 times, most recently from ecdab59 to 249a30f Compare November 8, 2024 12:40
@haseebsyed12 haseebsyed12 marked this pull request as ready for review November 8, 2024 13:21
Copy link
Contributor

@cardoe cardoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://argo-workflows.readthedocs.io/en/latest/walk-through/scripts-and-results/ and consider if the script: syntax would work better?

@haseebsyed12 haseebsyed12 changed the title feat: PUC-598: create or set baremetal flavour feat: PUC-598: create or set baremetal flavor Nov 11, 2024
Copy link
Contributor

@cardoe cardoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is a good first step. Ultimately need to walk over all the flavors in a defined repo and execute this.

Copy link
Contributor

@cardoe cardoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again. It's a step but no where addresses the needs asked. There's going to be flavors and we need to parse them and ensure they are applied. This workflow assumes someone will manually execute this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants