Changes to support url encoded header in repose 9 #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isenthilnatarajan
force-pushed
the
url_encoded_header
branch
from
a83fbf2
to
72ee2a9
Compare
scarlettmoonbell
suggested changes
Oct 23, 2019
manifests/filter/system_model.pp
Outdated
| @@ -137,6 +137,7 @@ | |||
| $rewrite_host_header = undef, | |||
| $service_cluster = undef, | |||
| $tracing_header = {}, | |||
| $encoded_headers = [], | |||
There was a problem hiding this comment.
One Style nitpick here - please lineup the "=" with the rest of the attributes.
Also please document the new attribute higher up in the file in the file following the style of documentation for the other attributes.
There was a problem hiding this comment.
@Bjoshua documented the new attribute and fixed this lineup
|
We will also need a review from @jstraw as he is part of the org in charge of this repo. |
jstraw
approved these changes
Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: