New cmp fix #110
Merged
New cmp fix #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check and store running processes in self.procs_out to save running 'ps' each time we need to check for process. Files can just be checked with os.path.exists instead of a dedicated function.
…er integration of additional checks. Added /usr/sbin/mysql for mysql detection. Still WIP
|
@popindavibe I like removing the curated list of files to compare, and have considered doing this in the past, however during testing I remember why it was done this way. The post phase diff output is polluted by dynamic runtime information that will be different during every execution; for example the Differences found against /root/test1/configsnap/ps.pre:
--- /root/test1/configsnap/ps.pre 2020-01-22 06:09:10.121000022 +0000
+++ /root/test1/configsnap/ps.post 2020-01-22 06:09:13.592000036 +0000
@@ -59 +59 @@
-root 1 0.0 0.1 19360 1532 ? Ss 05:41 0:01 /sbin/init
+root 1 0.0 0.1 19360 1536 ? Ss 05:41 0:01 /sbin/init
@@ -61,2 +61,2 @@
-root 1607 0.0 0.2 12340 2640 ? S< 05:42 0:00 \_ /sbin/udevd -d
-root 4940 1.0 0.0 4080 656 ? S< 06:09 0:00 | \_ /lib/udev/cdrom_id --export /dev/xvda
+root 1607 0.0 0.2 12340 2664 ? S< 05:42 0:00 \_ /sbin/udevd -d
+root 4968 0.0 0.0 4080 648 ? S< 06:09 0:00 | \_ /lib/udev/cdrom_id --export /dev/xvda
@@ -76,2 +76,2 @@
-root 4937 3.0 0.6 146212 6156 pts/0 S+ 06:09 0:00 \_ /usr/bin/python2 ./configsnap -t test1 -p pre
-root 4939 7.0 0.1 110356 1148 pts/0 R+ 06:09 0:00 \_ ps a u f x
+root 4966 3.0 0.6 146208 6156 pts/0 S+ 06:09 0:00 \_ /usr/bin/python2 ./configsnap -t test1 -p post
+root 4969 0.0 0.1 110356 1148 pts/0 R+ 06:09 0:00 \_ ps a u f xDo you think this additional info is distracting at all? It'll appear every time configsnap is run. Can you remove the version update and I'll continue testing, thanks! |
popindavibe
force-pushed
the
new_cmp_fix
branch
from
04edfba to
c0f6350
Compare
|
Updated PR to include specific exclusions on file comparison after change of paradigm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional changes following issue #108 and PR #109