Don't clobber request query string when passing params #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any update on this? Would love some feedback. 😄 |
|
Is there anything I can help with to get this merged? |
| uri.query = build_nested_query(params) | ||
| end | ||
|
|
||
| params = parse_nested_query(uri.query) |
There was a problem hiding this comment.
You can remove this, params is a local variable and not used afterwards.
|
Thanks for your contribution, it's definitely an improvement. But as mentioned your code is unnecessary complicated. Once you fix that, it should be merged. |
|
Had to push up a commit to fix the Rakefile to get the specs passing again. If you |
|
Wow, that was fast. 👍 (Travis will be fixed as well here, but doesn't hurt to have it here as well) |
brynary
added a commit
that referenced
this pull request
Feb 26, 2015
Don't clobber request query string when passing params
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm dealing with an API that requires the same query string key be passed multiple times. Normally Rack will parse the params and the last duplicate pair will win, but you can still parse the query string yourself if necessary. In certain cases in rack-test the query string is rebuilt from the parsed params which loses the duplicate keys altogether. This patch should fix that. Let me know if you have any questions.
Thanks!