Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors at rake docs and whitespace. #183

Merged
merged 1 commit into from
Jun 2, 2017

Conversation

junaruga
Copy link
Contributor

@junaruga junaruga commented May 31, 2017

This fixes #182

Summary

  • Fix rake whitespace.
    I changed the sed command format to run on GNU sed. Another version sed has been used before?
  • Change hanna to rdoc to generate RDoc document.
    Because hanna latest version 0.1.12 is using very old rake as runtime dependency.
    That causes install error.
    rdoc does not have any runtime dependency. It looks better.

Ref:

Use cases

whitespace

$ vi lib/rack/test.rb

$ git status
On branch hotfix/fix-rake-docs-and-whitespace
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

	modified:   lib/rack/test.rb
...

$ git diff
diff --git a/lib/rack/test.rb b/lib/rack/test.rb
index b7288c6..8aa3f85 100644
--- a/lib/rack/test.rb
+++ b/lib/rack/test.rb
@@ -6,7 +6,7 @@ require "rack/test/mock_digest_request"
 require "rack/test/utils"
 require "rack/test/methods"
 require "rack/test/uploaded_file"
-require "rack/test/version"
+require "rack/test/version"   <= tailing space
 
 module Rack
   module Test

$ bundle exec rake whitespace
find . -name '*.rb' -exec sed -i 's/ *$//g' {} \;

$ git status
<= no difference

docs

$ bundle exec rake docs
...
rdoc --title 'Rack::Test 0.6.3 API Documentation'
Parsing sources...
...

Then see doc/index.html.

* Fix rake whitespace.
  Change the sed command format to run on GNU sed.
* Change hanna to rdoc to generate rdoc document.
  Because hanna latest version 0.1.12 is using very old rake as runtime dependency.
  That causes install error.
  rdoc does not have any runtime dependency. It looks better.
Copy link

@dennissivia dennissivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@junaruga junaruga merged commit a5aa1e5 into rack:master Jun 2, 2017
@junaruga
Copy link
Contributor Author

junaruga commented Jun 2, 2017

Thanks for the reviewing!

alex-damian-negru pushed a commit to alex-damian-negru/rack-test that referenced this pull request Apr 5, 2021
* Fix rake whitespace.
  Change the sed command format to run on GNU sed.
* Change hanna to rdoc to generate rdoc document.
  Because hanna latest version 0.1.12 is using very old rake as runtime dependency.
  That causes install error.
  rdoc does not have any runtime dependency. It looks better.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error at rake docs and whitespace
2 participants