-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/bulk pr for readme updates #174
Feature/bulk pr for readme updates #174
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! It looks good to me!
@junaruga Sorry I am not sure the squash merge was right. It looks as if that results in me being the author. We could revert the merge and I will re-do the merge without sqashing. |
@scepticulous Ah in the case, the Squash Marge was not right. 3rd merge option (I forgot the name. The option is merging keeping original commits without merge commit.) was right. |
@scepticulous do not worry. Maybe we don't have to revert it. I will write |
@junaruga thanks again. Quick question. Your preferred way for the workflow is squash+merge for "ones own" PR and regular merge for things like this, where somebody merges someone's else PR for whatever reason? |
@scepticulous yes your recognition is correct. Some of the contributors do not like that original commit and their name has been removed when merging to master branch. |
@junaruga thanks for the update. I can also understand them and I think this process is fine for us as well. It would have been even less work for me in the first place. |
@scepticulous I might find a better operation by chance in another project about how to merge someone's PR keeping the original commit. Please look at below URL.
The upstream member was able to rebase my commit on another his branch. |
@junaruga I don't think it's actually a rebase in that PR you referred to, but rather targeting which branch it will merge into. |
@perlun oh okay. It's my mistake. Thanks for mentioning it. |
Maybe you're right, I don't know actually. :) |
* a small working example * Little readme tweaks
This PR implements PRs #65, #74, #76.
Some of the PRs contain similar content and other are no longer
based on the current readme. This is an attempt to clean up the
readme state.