Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test suite for Rack 2.x compatiblity. #148

Closed
wants to merge 1 commit into from
Closed

Conversation

voxik
Copy link
Contributor

@voxik voxik commented Sep 2, 2016

The test suite does not pass when testing against Rack 2.x. It fails with following error:

  1) Rack::Test::Utils build_multipart builds multipart bodies
     Failure/Error: params = Rack::Utils::Multipart.parse_multipart(env)
     NameError:
       uninitialized constant Rack::Utils::Multipart
     # ./spec/rack/test/utils_spec.rb:64:in `block (3 levels) in <top (required)>'

This is caused by this change rack/rack@b2d7396#diff-7c1a24d5b2fe58a6f925c7cacc6c55e7L573 in Rack.

@voxik
Copy link
Contributor Author

voxik commented Sep 2, 2016

@scepticulous you might want to incorporate this into your PR

@junaruga junaruga mentioned this pull request Oct 21, 2016
@junaruga
Copy link
Contributor

junaruga commented May 3, 2017

@voxik thanks for your pull-request. your commit was merged to master branch at #151 .

@junaruga junaruga closed this May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants