Test::UploadedFile: unintended breakage of public API

[perlun]

This is a regression in #149, reported by @tagliala and @007lva. Copying from a comment there:

---

Hi,

This change is breaking an use case in specs with Paperclip + FactoryBot.

The suggested method documented here: https://github.com/thoughtbot/paperclip#testing

FactoryGirl.define do
  factory :user do
    avatar { File.new("#{Rails.root}/spec/support/fixtures/image.jpg") }
  end
end

does not work anymore:

     NoMethodError:
       undefined method `size' for nil:NilClass
     # ~/dev/rack-test/lib/rack/test/uploaded_file.rb:38:in `public_send'
     # ~/dev/rack-test/lib/rack/test/uploaded_file.rb:38:in `method_missing'
     # ~/dev/rack-test/lib/rack/test/utils.rb:136:in `build_file_part'
     # ~/dev/rack-test/lib/rack/test/utils.rb:101:in `block in get_parts'
     # ~/dev/rack-test/lib/rack/test/utils.rb:92:in `each'
     # ~/dev/rack-test/lib/rack/test/utils.rb:92:in `map'
     # ~/dev/rack-test/lib/rack/test/utils.rb:92:in `get_parts'
     # ~/dev/rack-test/lib/rack/test/utils.rb:87:in `build_parts'
     # ~/dev/rack-test/lib/rack/test/utils.rb:77:in `build_multipart'
     # ~/dev/rack-test/lib/rack/test.rb:231:in `env_for'
     # ~/dev/rack-test/lib/rack/test.rb:128:in `custom_request'
     # ~/dev/rack-test/lib/rack/test.rb:66:in `post'

Is there any suggested way of doing this with rack-test 0.7.1? Should I report this to Paperclip?

I've tried several things but I'm unable to make it work.

TIA

[aebirim]

Hi,

This is occurring with me as well using FactoryBot (4.8.2), rspec-rails (3.7.2), ruby (2.4.2), rack-test (0.8.0)

  FactoryBot.define do
        factory :document do
            file Rack::Test::UploadedFile.new(File.new("#{Rails.root}/spec/fixtures/files/test_doc.doc"))
            initialize_with { new({ file: file }) }
         end
  end

Stacktrace:

#gems/ruby-2.4.2/gems/rack-test-0.8.0/lib/rack/test/uploaded_file.rb:58:in `initialize_from_io': Missing `original_filename` for IO (ArgumentError)
#gems/.rvm/gems/ruby-2.4.2/gems/rack-test-0.8.0/lib/rack/test/uploaded_file.rb:23:in `initialize'
#spec/factories/document.rb:3:in `new'
#spec/factories/document.rb:3:in `block (2 levels) in <top (required)>'
#.rvm/gems/ruby-2.4.2/gems/factory_bot-4.8.2/lib/factory_bot/syntax/default.rb:18:in `instance_eval'

When I roll back to rack-test 0.7.0, everything works fine.

Is there a way to get this to work in rack-test 0.8.0 ?

[Petercopter]

Getting this same error when converting a FactoryBot factory to JSON.

[perlun]

I think I have a fix for this, thanks to you all for your input. See #210 - please try that branch in your project and see if it works:

gem 'rack-test', github: 'rack-test/rack-test', branch: 'fix/uploaded-file-regression'

(I haven't seen this error myself, so I am a bit "walking in the dark here" - your input is highly valued!)

[aebirim]

just tested your fix and it works.

much appreciated for quick turnaround.

[Petercopter]

Just tested, works for me 👍 🌮 🍺

[007lva]

Update Capybara to 2.16.1 also fix the issue to me, due to this change:

teamcapybara/capybara@95a297e

[perlun]

Fix released in v0.8.2, published to Rubygems a minute ago. Enjoy!

[aebirim]

Sorry to be a pain guys but my error is reoccurring with rack-test 0.8.2.

Have also opened it as a new issue: #211

[tagliala]

Thanks!

@aebirim are you also using capybara?

[aebirim]

@tagliala not using Capybara. Using FactoryBot_Rails (4.8.2), rspec-rails (3.7.2), ruby (2.4.2)