Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use broccoli-funnel to allow excluding files/folders using regex #9

Merged
merged 1 commit into from
Apr 30, 2015

Conversation

craigteegarden
Copy link
Contributor

This PR replaces broccoli-file-remover with broccoli-funnel (https://github.com/broccolijs/broccoli-funnel) which allows excluding files from the tree using regular expressions.

We wanted to exclude all .map files, but they are automatically generated and there didn't seem to be a way to use the existing broccoli-file-remover with a glob/wildcard pattern.

This allows something like this to correctly remove index.html and any .map files from the output:

    manifest : {
      enabled: true,
      appcacheFile: "/manifest.appcache",
      excludePaths: ['index.html', new RegExp(/.\.map$/)],
      includePaths: [''],
      network: ['*']
    },

Thoughts?

@ssured
Copy link
Contributor

ssured commented Apr 30, 2015

Nice addition. I was unaware of the existence of broccoli-funnel . I'll pull in, thanks!

@ssured ssured merged commit 0503c63 into racido:master Apr 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants