Add tabindex for transcript lines #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
z4y4ts
suggested changes
Jan 31, 2017
dist/videojs-transcript.js
Outdated
| @@ -371,6 +371,7 @@ var widget = function (plugin) { | |||
| var timestamp = utils.createEl('span', '-timestamp'); | |||
| var text = utils.createEl('span', '-text'); | |||
| line.setAttribute('data-begin', cue.startTime); | |||
| line.setAttribute('tabindex', my._options.tabindex || 0); | |||
There was a problem hiding this comment.
Here and below my._options.tabIndex. To be camelCase.
dorosh
force-pushed
the
tabindex-for-transcript-lines
branch
from
953b07a to
72c9f2b
Compare
Add into options 'tabindex' for manage tabindex transcript lines
dorosh
force-pushed
the
tabindex-for-transcript-lines
branch
from
72c9f2b to
4d7b072
Compare
z4y4ts
approved these changes
Feb 1, 2017
dorosh
pushed a commit
that referenced
this pull request
Mar 21, 2017
* Feature/scroll to center (#1) * Auto scroll to the center of transcripts block. * Fix bower.json syntax.
z4y4ts
pushed a commit
that referenced
this pull request
Apr 21, 2017
* Auto scroll to the center of transcripts block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add into options 'tabindex' for manage tabindex transcript lines