Allow checking staged Apache artifacts

[raboof]

messy hack still, TODO generalize so that this can be a proper feature

[jrudolph]

Here's a diff that prevents rebuilding docs all the time when checking:

diff --git a/src/main/scala/ReproducibleBuildsPlugin.scala b/src/main/scala/ReproducibleBuildsPlugin.scala
index b6b3f23..98630c3 100644
--- a/src/main/scala/ReproducibleBuildsPlugin.scala
+++ b/src/main/scala/ReproducibleBuildsPlugin.scala
@@ -54,7 +54,7 @@ object ReproducibleBuildsPlugin extends AutoPlugin {
       reproducibleBuildsPackageName.value,
       version.value,
       scmInfo.value,
-      (packagedArtifacts in Compile).value,
+      artifactsWithoutDocs.value,
       (libraryDependencies in Compile).value,
       (scalaVersion in artifactName).value,
       (scalaBinaryVersion in artifactName).value,
@@ -62,6 +62,14 @@ object ReproducibleBuildsPlugin extends AutoPlugin {
     )
   }
 
+  // Since we do not care about docs and the docs task is not cached,
+  // we use a simplified version of `packagedArtifacts` that only includes jar and pom
+  // https://github.com/sbt/sbt/blob/2d7db22785726f30a95a0b2d7aea7ae5059ab51c/main/src/main/scala/sbt/Defaults.scala#L2788C3-L2791
+  // This might miss changes in other packaged artifacts that were added by the user.
+  lazy val artifactsWithoutDocs = Def.task {
+    Seq((Compile / makePom / packagedArtifact).value, (Compile / packageBin / packagedArtifact).value).toMap
+  }
+
   lazy val ourCertificationFile = Def.task[File] {
     val certification = ourCertification.value
 
@@ -122,7 +130,7 @@ object ReproducibleBuildsPlugin extends AutoPlugin {
       if (publishCertification.value) generatedArtifact else Map.empty[Artifact, File]
     },
     reproducibleBuildsCheckMavenCentral := {
-      val ourArtifacts = (packagedArtifacts in Compile).value
+      val ourArtifacts = artifactsWithoutDocs.value
       val url = artifactUrl(MavenCentral,"buildinfo").value
 
       val log = streams.value.log

[mdedetrich]

Here's a diff that prevents rebuilding docs all the time when checking:

Questioning the premise a bit, but shouldnt' we care about checking docs? Although generating docs right now is redundant because we never check the javadoc jars, is there a point in checking docs especially considering that docs can differ depending on which JDK you build them with (we have had these issues in Pekko)

[mdedetrich]

@raboof Would it be an issue to merge this for now and then release a new version? Its not perfect but more improvements can be done in the future and having this released would save a lot of time when checking for releases in Pekko.

[raboof]

@raboof Would it be an issue to merge this for now and then release a new version? Its not perfect but more improvements can be done in the future and having this released would save a lot of time when checking for releases in Pekko.

that's indeed my plan, still running some tests but planning to merge/release today

[raboof]

Here's a diff that prevents rebuilding docs all the time when checking:

would #257 also achieve that? or manually disabling the plugin for that subproject?

[mdedetrich]

would #257 also achieve that? or manually disabling the plugin for that subproject?

I think this is a separate issue, @jrudolph point seems to be "don't generate docs since we don't check doc jars" where as #257 is about not redundantly checking artifacts which the sbt build doesn't publish (i.e. causing erroneous Missing in theirs but present in ours)

[raboof]

@jrudolph point seems to be "don't generate docs since we don't check doc jars"

Ah, ofc 🤦 . If we do sign and publish doc jars, perhaps we should care about them though?

[mdedetrich]

Ah, ofc 🤦 . If we do sign and publish doc jars, perhaps we should care about them though?

Indeed, thats my opinion as well (i.e. we should be checking the checksum of javadoc jars).

[jrudolph]

@jrudolph point seems to be "don't generate docs since we don't check doc jars"

Ah, ofc 🤦 . If we do sign and publish doc jars, perhaps we should care about them though?

Not a strong opinion about that, it just seemed wasteful to rebuild apidocs all the time when don't check them anyway.