add support for sbt-assembly #152
Conversation
| scalaVersion := "2.12.7" | ||
|
|
||
| enablePlugins(ReproducibleBuildsPlugin) | ||
| enablePlugins(AssemblyPlugin) |
There was a problem hiding this comment.
Apparently I have to enable the Assembly for the reproducible hook to work, although the AssemblyPlugin is an auto plugin?
There was a problem hiding this comment.
That is indeed pretty weird.
Without this explicit call the assembly plugin was enabled, but indeed assembly called the original task instead of the 'reproducible' one.
Putting a $ pause in the scripted test right before the failing check, started an interactive sbt shell and did inspect assembly. Sure enough this confirmed assembly was the original assembly from AssemblyPlugin.scala:57.
I wonder if it's some sort of ordering or scoping thing?
There was a problem hiding this comment.
I can confirm that changing the order here matters, it won't work if the order was:
enablePlugins(AssemblyPlugin)
enablePlugins(ReproducibleBuildsPlugin)
somdoron
changed the title
|
@raboof aside from the enablePlugin issue this is ready on my side. Let me know if you have any comments. |
|
@somdoron what do you think about somdoron#1 ? |
|
Amazing, thanks |
|
refs #127 |
No description provided.