Remove @QuarkusTest for simple unit tests

rabobank · Aug 14, 2024 · 17bae7d · 17bae7d
1 parent f4b470b
commit 17bae7d
Show file tree

Hide file tree

Showing 7 changed files with 12 additions and 12 deletions.
diff --git a/git-plugin/pom.xml b/git-plugin/pom.xml
@@ -16,7 +16,7 @@
         </dependency>
         <dependency>
             <groupId>io.quarkus</groupId>
-            <artifactId>quarkus-rest-client-reactive-jackson</artifactId>
+            <artifactId>quarkus-rest-client-jackson</artifactId>
         </dependency>
 
         <dependency>

diff --git a/git-plugin/src/test/kotlin/io/rabobank/ret/git/plugin/AutoCompleteCommandTest.kt b/git-plugin/src/test/kotlin/io/rabobank/ret/git/plugin/AutoCompleteCommandTest.kt
@@ -1,6 +1,5 @@
 package io.rabobank.ret.git.plugin
 
-import io.quarkus.test.junit.QuarkusTest
 import io.rabobank.ret.IntelliSearch
 import io.rabobank.ret.RetContext
 import io.rabobank.ret.git.plugin.command.AutoCompleteCommand
@@ -31,7 +30,6 @@ import java.io.PrintWriter
 import java.io.StringWriter
 import java.time.ZonedDateTime
 
-@QuarkusTest
 class AutoCompleteCommandTest {
     private lateinit var commandLine: CommandLine
     private val gitProvider = mock<GitProvider>()

diff --git a/git-plugin/src/test/kotlin/io/rabobank/ret/git/plugin/PullRequestCreateCommandTest.kt b/git-plugin/src/test/kotlin/io/rabobank/ret/git/plugin/PullRequestCreateCommandTest.kt
@@ -1,6 +1,5 @@
 package io.rabobank.ret.git.plugin
 
-import io.quarkus.test.junit.QuarkusTest
 import io.rabobank.ret.RetContext
 import io.rabobank.ret.git.plugin.command.PullRequestCreateCommand
 import io.rabobank.ret.git.plugin.config.ExceptionMessageHandler
@@ -29,7 +28,6 @@ import java.net.URI
 
 private const val BASE_URL = "https://test.git"
 
-@QuarkusTest
 internal class PullRequestCreateCommandTest {
     private val gitProvider = mock<GitProvider>()
     private val mockedBrowserUtils = mock<BrowserUtils>()

diff --git a/git-plugin/src/test/kotlin/io/rabobank/ret/git/plugin/PullRequestOpenCommandTest.kt b/git-plugin/src/test/kotlin/io/rabobank/ret/git/plugin/PullRequestOpenCommandTest.kt
@@ -1,6 +1,5 @@
 package io.rabobank.ret.git.plugin
 
-import io.quarkus.test.junit.QuarkusTest
 import io.rabobank.ret.git.plugin.command.PullRequestOpenCommand
 import io.rabobank.ret.git.plugin.output.OutputHandler
 import io.rabobank.ret.git.plugin.provider.GitProvider
@@ -23,7 +22,6 @@ import java.net.URI
 
 private const val BASE_URL = "https://test.git"
 
-@QuarkusTest
 internal class PullRequestOpenCommandTest {
     private val mockedGitProvider = mock<GitProvider>()
     private val mockedBrowserUtils = mock<BrowserUtils>()

diff --git a/git-plugin/src/test/kotlin/io/rabobank/ret/git/plugin/RepositoryCommandTest.kt b/git-plugin/src/test/kotlin/io/rabobank/ret/git/plugin/RepositoryCommandTest.kt
@@ -1,6 +1,5 @@
 package io.rabobank.ret.git.plugin
 
-import io.quarkus.test.junit.QuarkusTest
 import io.rabobank.ret.RetConsole
 import io.rabobank.ret.RetContext
 import io.rabobank.ret.git.plugin.command.RepositoryCommand
@@ -26,7 +25,6 @@ import org.mockito.kotlin.whenever
 import picocli.CommandLine
 import java.net.URI
 
-@QuarkusTest
 internal class RepositoryCommandTest {
     private val mockedGitProvider = mock<GitProvider>()
     private val mockedBrowserUtils = mock<BrowserUtils>()

diff --git a/splunk-plugin/pom.xml b/splunk-plugin/pom.xml
@@ -16,7 +16,7 @@
         </dependency>
         <dependency>
             <groupId>io.quarkus</groupId>
-            <artifactId>quarkus-rest-client-reactive-jackson</artifactId>
+            <artifactId>quarkus-rest-client-jackson</artifactId>
         </dependency>
         <dependency>
             <groupId>org.jetbrains.kotlin</groupId>

diff --git a/splunk-plugin/src/main/kotlin/io/rabobank/ret/splunk/plugin/splunk/SplunkPluginConfig.kt b/splunk-plugin/src/main/kotlin/io/rabobank/ret/splunk/plugin/splunk/SplunkPluginConfig.kt
@@ -19,8 +19,16 @@ class SplunkPluginConfig : Configurable() {
 
     override fun properties() =
         listOf(
-            ConfigurationProperty(BASE_URL, "Enter the Splunk base URL (<base-url> in <base-url>/en-US/app/<app-name>/search)", required = true),
-            ConfigurationProperty(APP, "Enter your Splunk app name (<app-name> in <base-url>/en-US/app/<app-name>/search)", required = true),
+            ConfigurationProperty(
+                BASE_URL,
+                "Enter the Splunk base URL (<base-url> in <base-url>/en-US/app/<app-name>/search)",
+                required = true,
+            ),
+            ConfigurationProperty(
+                APP,
+                "Enter your Splunk app name (<app-name> in <base-url>/en-US/app/<app-name>/search)",
+                required = true,
+            ),
             ConfigurationProperty(
                 INDEXES,
                 "Enter your Splunk index(es) (comma separated). E.g. my_index_a, my_index_b",