Preview the website locally with a single command: make preview #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves all dependencies, tested on macOS 10.13 & Arch Linux 2018.09.01
lukebakken
reviewed
Sep 4, 2018
| [dev-packages] | ||
|
|
||
| [requires] | ||
| python_version = "3.7" |
There was a problem hiding this comment.
Is there a way of stating a minimum Python version instead?
There was a problem hiding this comment.
Answer, nope: pypa/pipenv#1050
lukebakken
reviewed
Sep 4, 2018
lukebakken
approved these changes
Sep 4, 2018
michaelklishin
approved these changes
Sep 4, 2018
|
Thank you both for the quick sanity check & merge, I'll make the other trivial changes related to this directly in
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves all dependencies, tested on macOS 10.13 & Arch Linux 2018.09.01
I had this sitting in #546 for too long now, it was high time to split out and submit on its own.