Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing bug when consuming from OffsetSpecification:Offset #223

Merged
merged 1 commit into from
Aug 11, 2024

Conversation

DanielePalaia
Copy link
Contributor

This closes #222

@DanielePalaia DanielePalaia marked this pull request as draft August 8, 2024 07:42
@DanielePalaia DanielePalaia force-pushed the fix_for_offset_specification_offset branch from 5aa44ce to 3550d36 Compare August 8, 2024 07:45
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.30%. Comparing base (b960884) to head (3550d36).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #223      +/-   ##
==========================================
+ Coverage   89.15%   89.30%   +0.15%     
==========================================
  Files          69       69              
  Lines        5742     5749       +7     
==========================================
+ Hits         5119     5134      +15     
+ Misses        623      615       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DanielePalaia DanielePalaia marked this pull request as ready for review August 8, 2024 08:04
@DanielePalaia
Copy link
Contributor Author

Hey @wolf4ood I tested the fix with the example in the issue with different offsets and it seems working. If you want to have a look when you have time!

Copy link
Contributor

@wolf4ood wolf4ood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanielePalaia DanielePalaia merged commit 7d03b52 into main Aug 11, 2024
4 checks passed
@DanielePalaia DanielePalaia deleted the fix_for_offset_specification_offset branch August 11, 2024 11:59
@github-actions github-actions bot mentioned this pull request Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue starting the Consumer from a given offset
2 participants