-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic send and batch send splits for milestone 1.5 #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriele Santomaggio <[email protected]>
Signed-off-by: Gabriele Santomaggio <[email protected]>
- Add Dynamic send - Fix super stream test Signed-off-by: Gabriele Santomaggio <[email protected]>
automatically splits the frames. Removes the messages too big for the frame. Add the batch result to give more control to the user Signed-off-by: Gabriele Santomaggio <[email protected]>
…-client into dynamic_send
automatically splits the frames. Removes the messages too big for the frame. Add the batch result to give more control to the user Signed-off-by: Gabriele Santomaggio <[email protected]>
Gsantomaggio
changed the title
Dynamic send
Dynamic send and batch send splits for milestone 1.5
Dec 3, 2024
Signed-off-by: Gabriele Santomaggio <[email protected]>
Signed-off-by: Gabriele Santomaggio <[email protected]>
add unConfirmed struct to balance the unconfirm messages. refactor code Signed-off-by: Gabriele Santomaggio <[email protected]>
Signed-off-by: Gabriele Santomaggio <[email protected]>
Signed-off-by: Gabriele Santomaggio <[email protected]>
hiimjako
reviewed
Dec 17, 2024
Co-authored-by: Alberto Moretti <[email protected]>
Co-authored-by: Alberto Moretti <[email protected]>
Co-authored-by: Alberto Moretti <[email protected]>
Co-authored-by: Alberto Moretti <[email protected]>
Signed-off-by: Gabriele Santomaggio <[email protected]>
Signed-off-by: Gabriele Santomaggio <[email protected]>
Signed-off-by: Gabriele Santomaggio <[email protected]>
hiimjako
previously approved these changes
Dec 28, 2024
* remove the code duplication when the producer is closed correctly or not * make the unconfirmed operation more atomic to avoid rare cases when the unconfirmed operations were out of the mutex lock * Increase the timeout for the Reliable producers and consumers. It was too low. Now, there is one more wait for the producer to wait for pending messages to be flushed when closed. * refactor publish confirm channel with a lock to check if it is valid or not and avoid race conditions during the closing * handle when the producer is not found during the confirmation. It can happen when the producer is closed before all the messages are confirmed Signed-off-by: Gabriele Santomaggio <[email protected]>
* remove the code duplication when the producer is closed correctly or not * make the unconfirmed operation more atomic to avoid rare cases when the unconfirmed operations were out of the mutex lock * Increase the timeout for the Reliable producers and consumers. It was too low. Now, there is one more wait for the producer to wait for pending messages to be flushed when closed. * refactor publish confirm channel with a lock to check if it is valid or not and avoid race conditions during the closing * handle when the producer is not found during the confirmation. It can happen when the producer is closed before all the messages are confirmed Signed-off-by: Gabriele Santomaggio <[email protected]>
Signed-off-by: Gabriele Santomaggio <[email protected]>
Signed-off-by: Gabriele Santomaggio <[email protected]>
Signed-off-by: Gabriele Santomaggio <[email protected]>
Signed-off-by: Gabriele Santomaggio <[email protected]>
Signed-off-by: Gabriele Santomaggio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.5 Milestone
The PR contains code refactoring. Focus on increasing the stability during the reconnection and introducing the dynamic send.
News:
Update to Golang 1.22.0
Removed the aggregation via timeout and implemented the dynamic send. The goal is to reduce the latency, especially in low-rate use cases. Low-rate use cases are the most used.
The dynamic send is a wrapper around the
BatchSend()
that will remain public for the users who want more control during the send.Refactor Producer close. Remove the code duplication when the producer is closed correctly or not
Make the unconfirmed operation more atomic to avoid rare cases when the unconfirmed operations were out of the mutex lock
Increase the timeout for the Reliable producers and consumers. It was too low. Now, there is one more wait for the producer to wait for pending messages to be flushed when closed.
Refactor publish confirm channel with a lock to check if it is valid or not and avoid race conditions during the closing
Handle when the producer is not found during the confirmation. It can happen when the producer is closed before all the messages are confirmed
Test results
PerTest with a limit rate of 50 Messages per second
Given:
With this PR the latency is around 5 ms
Main branch (
1.4.x
), the latency is around 90 ms ( The timeout for the aggregation )With the dynamic send, the latency is reduced, especially with a low rate, which is the most common use case.