temporany remove windows test due of actions/checkout#1186

Signed-off-by: Gabriele Santomaggio <[email protected]>
rabbitmq · Jan 8, 2025 · d1db816 · d1db816
1 parent 3bbc832
commit d1db816
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 24 deletions.
diff --git a/.github/workflows/build_and_test.yml b/.github/workflows/build_and_test.yml
@@ -63,30 +63,31 @@ jobs:
           verbose: true # optional (default = false)
         env:
           CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
-  test-win32:
-    runs-on: windows-latest
-    strategy:
-      matrix:
-        go: [ '1.22']
-    steps:
-      - uses: actions/checkout@v4
-      - uses: actions/setup-go@v5
-        id: setup_go
-        with:
-          go-version: ${{ matrix.go }}
-          check-latest: true
-      - name: Cache installers
-        uses: actions/cache@v4
-        with:
-          # Note: the cache path is relative to the workspace directory
-          # https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows#using-the-cache-action
-          path: ~/installers
-          key: ${{ runner.os }}-v0-${{ hashFiles('.ci/versions.json') }}
-      - name: Install and start RabbitMQ
-        run: ./.ci/install.ps1
-      - name: Install GNU make
-        run: choco install make
-      - run: make test GO_VERSION=${{ steps.setup_go.outputs.go-version }}
+  # temporany removed due of https://github.com/actions/checkout/issues/1186
+  # test-win32:
+  #   runs-on: windows-latest
+  #   strategy:
+  #     matrix:
+  #       go: [ '1.22']
+  #   steps:
+  #     - uses: actions/checkout@v4
+  #     - uses: actions/setup-go@v5
+  #       id: setup_go
+  #       with:
+  #         go-version: ${{ matrix.go }}
+  #         check-latest: true
+  #     - name: Cache installers
+  #       uses: actions/cache@v4
+  #       with:
+  #         # Note: the cache path is relative to the workspace directory
+  #         # https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows#using-the-cache-action
+  #         path: ~/installers
+  #         key: ${{ runner.os }}-v0-${{ hashFiles('.ci/versions.json') }}
+  #     - name: Install and start RabbitMQ
+  #       run: ./.ci/install.ps1
+  #     - name: Install GNU make
+  #       run: choco install make
+  #     - run: make test GO_VERSION=${{ steps.setup_go.outputs.go-version }}
   publish:
     runs-on: ubuntu-latest 
     needs: [test]

diff --git a/pkg/integration_test/stream_integration_test.go b/pkg/integration_test/stream_integration_test.go
@@ -50,6 +50,9 @@ var _ = Describe("StreamIntegration", func() {
 				for {
 					select {
 					case confirmations := <-confirmationCh:
+						for i := range confirmations {
+							Expect(confirmations[i].IsConfirmed()).To(BeTrue())
+						}
 						for range confirmations {
 							count += 1
 							if count == totalExpected {
@@ -113,6 +116,8 @@ var _ = Describe("StreamIntegration", func() {
 				Expect(err).ToNot(HaveOccurred())
 			}
 
+			// wait a bit. We don't have confirmation here
+
 			// We should receive only 100 messages because Next sends the next chunk
 			// in the stream. The previously 100 messages should be in a different chunk
 			By("receiving only new messages")