Use stable version of Go in CI

We started developing in Go 1.21 because slog package became GA in Go 1.21. The toolchain directive in go.mod is new and only available in Go 1.21. We have to temporarily bump the Go version in CI to 'stable'. We will provide compatibility to oldstable at a later date. Signed-off-by: Aitor Perez Cedres <[email protected]>
rabbitmq · Nov 17, 2023 · 947e258 · 947e258
1 parent 57bf7bc
commit 947e258
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 92 deletions.
diff --git a/.github/workflows/build_test_linux.yml b/.github/workflows/build_test_linux.yml
@@ -17,7 +17,8 @@ jobs:
     - name: Set up Go
       uses: actions/setup-go@v4
       with:
-        go-version: oldstable
+        go-version: stable
+#        go-version: oldstable
 
     - name: Build
       run: make build
@@ -50,7 +51,8 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v4
         with:
-          go-version: oldstable
+          go-version: stable
+#          go-version: oldstable
 
       - name: E2E Tests
         env:

diff --git a/pkg/e2e/end_to_end_test.go b/pkg/e2e/end_to_end_test.go
@@ -249,7 +249,7 @@ var _ = Describe("E2E", Serial, Label("e2e"), func() {
 		streamClientConfiguration, err := raw.NewClientConfiguration(rabbitmqUri)
 		Expect(err).ToNot(HaveOccurred())
 		connectionName := "notify-disconnection-test-1"
-		streamClientConfiguration.SetConnectionName(connectionName)
+		streamClientConfiguration.ConnectionName = connectionName
 
 		By("preparing the environment")
 		streamClient, err := raw.DialConfig(itCtx, streamClientConfiguration)

diff --git a/pkg/stream/environment_internal_test.go b/pkg/stream/environment_internal_test.go
diff --git a/pkg/stream/environment_test.go b/pkg/stream/environment_test.go
@@ -281,12 +281,15 @@ var _ = Describe("Environment", func() {
 					Return(errors.New("something went wrong"))
 			})
 
-			It("logs the error and moves on", Pending, func() {
-				// TODO: the locator has its own logger, it does not use the logger
-				// 	from the context. This tests seems to make no sense, as the
-				// 	locator is appended by an utility function for tests, and
-				//	this tests assumes that the locator uses the logger from context,
-				//	which is not true. Revisit this test and its assumptions.
+			It("logs the error and moves on", func() {
+				Skip("the locator has its own logger, it does not use the logger from the context. This tests seems to make no sense, as the locator is appended by an utility function for tests, and this tests assumes that the locator uses the logger from context, which is not true. Revisit this test and its assumptions")
+				/*
+					TODO: the locator has its own logger, it does not use the logger
+						from the context. This tests seems to make no sense, as the locator is appended
+						by an utility function for tests, and this tests assumes that the locator uses
+						the logger from context, which is not true. Revisit this test and its
+						assumptions.
+				*/
 				logBuffer := gbytes.NewBuffer()
 				logger := slog.New(slog.NewTextHandler(logBuffer, nil))
 				ctx := raw.NewContextWithLogger(context.Background(), *logger)