Don't log and return the error when validating input.

rabbitmq · Sep 28, 2023 · 2a2d7f4 · 2a2d7f4
1 parent e4b2672
commit 2a2d7f4
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 4 deletions.
diff --git a/pkg/stream/environment.go b/pkg/stream/environment.go
@@ -311,7 +311,6 @@ func (e *Environment) QuerySequence(ctx context.Context, reference, stream strin
 
 	if !validateStringParameter(reference) {
 		lastError = fmt.Errorf("producer reference invalid: %s", reference)
-		logger.Error("invalid producer reference", slog.Any("error", lastError))
 		return uint64(0), lastError
 	}
 

diff --git a/pkg/stream/environment_test.go b/pkg/stream/environment_test.go
@@ -672,9 +672,6 @@ var _ = Describe("Environment", func() {
 					environment.AppendLocatorRawClient(locator2rawClient)
 					environment.SetBackoffPolicy(backOffPolicyFn)
 					environment.SetLocatorSelectSequential(true)
-
-					// have to set server version again because there's a new locator
-					// environment.SetServerVersion("3.11.1")
 				})
 
 				It("uses different locators when one fails", func() {