rabbitmq_ct_helpers: Detect crashes in RabbitMQ logs #9290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dumbbell
changed the title
[Why]
Some crashes may go under the radar if a testcase didn't check
everything (which is hard to do anyway). It could be useful to be aware
of those crashes.
[How]
This new check will search for any logged crashes in the RabbitMQ log
files and throw an exception as part of stopping a node.
V2: This facility can be disabled by setting `find_crashes` to false in
the common_test's `Config`, or by setting the `$FIND_CRASHES`
environment variable to anything but "1"/"yes"/"true".
dumbbell
force-pushed
the
search-for-crashes-in-test-nodes
branch
from
bafc38a to
cb8b0bf
Compare
ansd
reviewed
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Some crashes may go under the radar if a testcase didn't check everything (which is hard to do anyway). It could be useful to be aware of those crashes.
How
This new check will search for any logged crashes in the RabbitMQ log files and throw an exception as part of stopping a node.
V2: This facility can be disabled by setting
find_crashesto false in the common_test'sConfig, or by setting the$FIND_CRASHESenvironment variable to anything but "1"/"yes"/"true".