Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RabbitMQ Streams uses incorrect keys for RouteResponse and PartitionResponse #5956

Closed
evnu opened this issue Oct 1, 2022 · 0 comments · Fixed by #5961
Closed

RabbitMQ Streams uses incorrect keys for RouteResponse and PartitionResponse #5956

evnu opened this issue Oct 1, 2022 · 0 comments · Fixed by #5961
Milestone
3.11.1

Comments

@evnu
Copy link

evnu commented Oct 1, 2022

RouteResponse and PartitionResponse use the same keys as RouteQuery and PartitionQuery. Thus, the response for the queries appear to be queries as well, but their structure adheres to the correct response structure defined in the documentation. The response frames are not built using the rabbit_stream_core:frame/1 function, which is probably the culprit for the mismatch. See the response for RouteQuery:

    Frame =
        <<?COMMAND_ROUTE:16,
          ?VERSION_1:16,
          CorrelationId:32,
          ResponseCode:16,
          StreamBin/binary>>,
acogoluegnes added a commit that referenced this issue Oct 3, 2022
@acogoluegnes
Fix keys for route and partitions responses
0c1eeab 
These 2 responses were not using the `rabbit_stream_core` utilities
so they were not using the "prefix" for responses.

Fixes #5956
@acogoluegnes acogoluegnes mentioned this issue Oct 3, 2022
Merged
@acogoluegnes acogoluegnes added this to the 3.11.1 milestone Oct 3, 2022
mergify bot pushed a commit that referenced this issue Oct 3, 2022
@acogoluegnes @mergify
Fix keys for route and partitions responses
bb44082 
These 2 responses were not using the `rabbit_stream_core` utilities
so they were not using the "prefix" for responses.

Fixes #5956

(cherry picked from commit 0c1eeab)

# Conflicts:
#	deps/rabbitmq_stream/src/rabbit_stream.erl
#	deps/rabbitmq_stream/src/rabbit_stream_connection_sup.erl
acogoluegnes added a commit that referenced this issue Oct 4, 2022
@acogoluegnes
Use supervisor2 specifications in stream connection supervisor
47a5531 
The supervisor specifications were dragged from main because
of formatting changes.

References #5956
acogoluegnes added a commit that referenced this issue Oct 4, 2022
@acogoluegnes
Remove auto_shutdown from supervisor2 flags
6015147 
Not supported.

References #5956
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.11.1
Development

Successfully merging a pull request may close this issue.

Fix keys for route and partitions responses rabbitmq/rabbitmq-server
2 participants
@evnu @acogoluegnes