-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add activity on connection #1734
base: main
Are you sure you want to change the base?
Conversation
} | ||
|
||
Activity? connectionActivity = | ||
s_connectionSource.StartRabbitMQActivity("rabbitmq connect", ActivityKind.Client); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename "rabbitmq connect" to "connection.open". It is obvious that this client will connect to a RabbitMQ node.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok to rename but activity name is used in all UI when traces are ingested, I highly recommand to set a more human friendly name like "connection open"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"connection open" (with a space) is not grammatically correct. "connection.open" is a protocol frame name but I can see how that'd be too obscure.
"connection attempt" can be used before we know that the connection succeeded. "connection opened" can be used after a successful connection. In fact, both can be used at the same time in different places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"connection attempt" should be good because we do not know if its a success.
Span status will be set to ERROR and an exception event will be attached to the current span if it fails.
Proposed Changes
Add activity on connection creation.
In case of creation exception register an error event.
Types of Changes
What types of changes does your code introduce to this project?
Put an
x
in the boxes that applyRefer to #1731