Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc fixes #10

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Misc fixes #10

merged 1 commit into from
Jul 1, 2024

Conversation

lukebakken
Copy link
Contributor

@lukebakken lukebakken commented Jun 28, 2024

  • Add solution items
  • Use default LangVersion

@lukebakken lukebakken self-assigned this Jun 28, 2024
@Gsantomaggio
Copy link
Member

Do we want to support only .8 ?

@lukebakken
Copy link
Contributor Author

lukebakken commented Jul 1, 2024

https://dotnet.microsoft.com/en-us/platform/support/policy/dotnet-core

I was having issues with tests running correctly with all three TFMs in the projects. I'll look into adding net6.0 and net7.0 back.

Note that if we wanted to support as many versions of .NET, we'd do what AmqpNet.Core does -
https://www.nuget.org/packages/AMQPNetLite.Core#supportedframeworks-body-tab

https://learn.microsoft.com/en-us/dotnet/standard/net-standard?tabs=net-standard-1-0

@lukebakken
Copy link
Contributor Author

@Gsantomaggio I'm currently seeing how much of a pain supporting netstandard2.0 is, like we do with the AMQP 0.9.1 .NET client.

@Gsantomaggio
Copy link
Member

@lukebakken I don't have any strong opinion on support versions >= net.8
I asked just because if we want to support only >= 8 we can remove https://github.com/rabbitmq/rabbitmq-amqp-dotnet-client/blob/main/Directory.Packages.props#L22 System.Diagnostics.DiagnosticSource" an use the new .NET 8 library for the metrics: https://www.mytechramblings.com/posts/getting-started-with-opentelemetry-metrics-and-dotnet-part-1/

* Add solution items
* Use `default` `LangVersion`
* Port CI scripts from rabbitmq/rabbitmq-dotnet-client@main
* Upgrade dependencies
* Use `ThrowsAnyAsync` because `System.Net.Internals.SocketExceptionFactory+ExtendedSocketException` may be thrown.
@lukebakken lukebakken marked this pull request as ready for review July 1, 2024 18:12
Copy link
Member

@Gsantomaggio Gsantomaggio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lukebakken 😃

@lukebakken lukebakken merged commit 6421cdb into main Jul 1, 2024
1 check passed
@lukebakken lukebakken deleted the lukebakken/misc branch July 1, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants