Add ra_machine:snapshot_installed/4 callback to pass old state
#467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-mikedavis
force-pushed
the
md/snapshot-installed-old-state
branch
from
bb086ef
to
3e2f52e
Compare
the-mikedavis
force-pushed
the
md/snapshot-installed-old-state
branch
from
3e2f52e
to
0290e03
Compare
dumbbell
approved these changes
Aug 27, 2024
michaelklishin
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an extended version of the existing
Machine:snapshot_installed(SnapMeta, NewState)callback which adds parameters for the old state: the state of the machine before the snapshot was installed and also its version since the snapshot installation might cause a version bump.This is meant for any machine that needs to diff the old and new states. For example Khepri needs this (see rabbitmq/khepri#290) to update its projections when either the projections change or any part of the tree which is covered by a projection's pattern.