khepri_machine: Define the Ra machine version to 0 #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #230 +/- ##
==========================================
- Coverage 88.77% 88.74% -0.04%
==========================================
Files 20 20
Lines 2895 2896 +1
==========================================
Hits 2570 2570
- Misses 325 326 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dumbbell
force-pushed
the
define-ra-machine-version
branch
from
6fc438d
to
b42ee54
Compare
dumbbell
changed the title
dumbbell
force-pushed
the
define-ra-machine-version
branch
from
b42ee54
to
c7da3a8
Compare
dumbbell
force-pushed
the
define-ra-machine-version
branch
from
c7da3a8
to
5b2c607
Compare
[Why] This is not required at this point. However, users can query the machine version without having to worry if the callback is defined (version = 0 when the callback is missing) or not. [How] We define the first version to be 0.
dumbbell
force-pushed
the
define-ra-machine-version
branch
from
5b2c607
to
4b6a395
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This is not required at this point. However, users can query the machine version without having to worry if the callback is defined (version = 0 when the callback is missing) or not.
How
We define the first version to be 0.
Depends on rabbitmq/ra#399.