Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linter errors #1736

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Fix linter errors #1736

merged 2 commits into from
Sep 27, 2024

Conversation

Zerpet
Copy link
Collaborator

@Zerpet Zerpet commented Sep 26, 2024

This closes #

Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed

Summary Of Changes

  • Fix linter errors
  • Unexport functions in scaling test suite

Additional Context

The linter is staticcheck, latest version at this time 2024.1.1. The errors reported were:

  • Duplicated imports
  • Variables shadowing a package name

Local Testing

  • Unit tests passing after changes
  • Integration tests passing after changes

Fixed errors reported by staticcheck version 2024.1.1
Those functions and structs are specific and used only in the scaling
tests. It is not necessary to export them.
@Zerpet Zerpet added this to the v2.11.0 milestone Sep 26, 2024
@Zerpet Zerpet self-assigned this Sep 26, 2024
@Zerpet Zerpet merged commit f61a015 into main Sep 27, 2024
15 checks passed
@Zerpet Zerpet deleted the fix/linter branch September 27, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants