interactive flow maps vignette #76
Conversation
|
will resolve manually |
|
ok, fixed all issues with this one, ready for review |
There was a problem hiding this comment.
This is 5MB. To keep the package 'lightweight' I would refrain from checking-in any files more than ~300kb into the repo. This could cause issues given CRAN's max pkg size of 5MB. On the other hand, it is beautiful. One 'hack' is you can paste gifs into GitHub issues or elsewhere on GitHub without polluting the commit history with large files. No big issue for now, just one to think about next time.
There was a problem hiding this comment.
@Robinlovelace I exclude all animations with Rbuildignore and replace with static images. So not an issue at all. Animations only go to github and into pkgdown
There was a problem hiding this comment.
Ahh, there may be a problem with CRAN complaining about missing images, as these will be linked in the MD file. But we can replace them with direct links to repo or to the pkgdownwebsite
No description provided.