Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reconsider some functions #5

Open
antagomir opened this issue Nov 3, 2024 · 0 comments
Open

reconsider some functions #5

antagomir opened this issue Nov 3, 2024 · 0 comments

Comments

@antagomir
Copy link
Member

Function integrate_metadata seems to only do one-liner running tidyverse join. Adding such wrapper adds very limited value, adds maintenance burden, may reduce the flexibility of options, and less functionality less transparent.

-> Remove very short wrappers and instead replace them in the examples with the original tidyverse / ggplot or other functionality. Only if the wrapper adds something substantial we can consider keeping.

ake123 added a commit that referenced this issue Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant