Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rogtemplate to eurostat #229

Merged
merged 7 commits into from
Sep 29, 2021
Merged

Add rogtemplate to eurostat #229

merged 7 commits into from
Sep 29, 2021

Conversation

dieghernan
Copy link
Member

@dieghernan dieghernan commented Sep 29, 2021

Copy link
Member

@antagomir antagomir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me! Shall we merge after the checks? Some checks seem to fail still.

@dieghernan
Copy link
Member Author

I’ll wait until #228 is merged to avoid conflict. Check are failing because the action can’t download rcmdcheck on Ubuntu devel:

ubuntu-20.04 (devel)
there is no package called ‘rcmdcheck’

So this is not related with the PR, it seems to be a temporary issue (hope so, all packages are failing now for the same reason)

ping @pitkant

@dieghernan
Copy link
Member Author

Hi @antagomir

I also updated the README adding the DOI of R-Journal https://doi.org/10.32614/RJ-2017-019 and updated the citation to best align with the one provided there.

As this can be a sensitive change I would wait for your feedback

@antagomir antagomir marked this pull request as ready for review September 29, 2021 21:19
@antagomir antagomir merged commit e6c2504 into master Sep 29, 2021
@dieghernan dieghernan deleted the rogtemplate branch September 29, 2021 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sticker for eurostat Create release & Add DOI in README
2 participants